Skip to content

Conversation

@patrick96
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

When the bar is hidden, the struts should be 0 so that WMs can resize
their windows and not leave a gap.

Related Issues & Documents

Ref #2701

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

When the bar is hidden, the struts should be 0 so that WMs can resize
their windows and not leave a gap.

Ref polybar#2701
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #2702 (641257e) into hotfix/3.6.3 (bc9dda2) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 641257e differs from pull request most recent head c229505. Consider uploading reports for the commit c229505 to get more accurate results

@@               Coverage Diff                @@
##           hotfix/3.6.3    #2702      +/-   ##
================================================
- Coverage         13.77%   13.76%   -0.01%     
================================================
  Files               153      153              
  Lines             11292    11296       +4     
================================================
  Hits               1555     1555              
- Misses             9737     9741       +4     
Flag Coverage Δ
unittests 13.76% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/bar.cpp 0.00% <0.00%> (ø)
src/x11/window.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc9dda2...c229505. Read the comment docs.

@patrick96 patrick96 merged commit efbd8e3 into polybar:hotfix/3.6.3 Apr 27, 2022
@patrick96 patrick96 added this to the 3.6.3 milestone Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant