Skip to content

fix: No overlines/underlines being drawn when using offsets #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
patrick96 merged 1 commit into from
Apr 11, 2022
Merged

fix: No overlines/underlines being drawn when using offsets #2685

patrick96 merged 1 commit into from
Apr 11, 2022

Conversation

@patrick96
Copy link
Member

@patrick96 patrick96 commented Apr 11, 2022 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Minimal example

[bar/example]
modules-left = text
line-size = 2
width = 100

[module/text]
type = custom/text
content = Foo %{O10} Bar
content-underline = #ff0000

Broken:

broken

Fixed:

fixed

Related Issues & Documents

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

@patrick96 patrick96 added this to the 3.6.3 milestone Apr 11, 2022
@patrick96 patrick96 force-pushed the fix/offset-underline branch from 5fceb7d to f9bb4ee Compare April 11, 2022 19:16
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #2685 (f9bb4ee) into hotfix/3.6.3 (146c1ac) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           hotfix/3.6.3    #2685      +/-   ##
================================================
- Coverage         13.77%   13.77%   -0.01%     
================================================
  Files               153      153              
  Lines             11286    11291       +5     
================================================
  Hits               1555     1555              
- Misses             9731     9736       +5
Flag Coverage Δ
unittests 13.77% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/renderer.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 146c1ac...f9bb4ee. Read the comment docs.

@patrick96 patrick96 merged commit ab206a5 into polybar:hotfix/3.6.3 Apr 11, 2022
@patrick96 patrick96 deleted the fix/offset-underline branch April 11, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.6.3

Development

Successfully merging this pull request may close these issues.

1 participant

@patrick96