Skip to content

Conversation

@nathanaelhoun
Copy link
Contributor

@nathanaelhoun nathanaelhoun commented Mar 5, 2022

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

As stated in the 3.6.0 changelog,

polybar-msg hook is deprecated in favor of using the hook action. polybar-msg will tell you the correct command to use.

However, it instructs to use another polybar-msg hook command, instead of polybar-msg action.

Current :

$ polybar-msg hook count-updates_ipc 1
Warning: Using IPC hook commands is deprecated, use the hook action on the ipc module: polybar-msg hook "#count-updates_ipc.hook.0"
Successfully wrote action '#count-updates_ipc.hook.0' to PID 33971

Fixed :

$ /usr/local/bin/polybar-msg hook count-updates_ipc 1
Warning: Using IPC hook commands is deprecated, use the hook action on the ipc module: /usr/local/bin/polybar-msg action "#count-updates_ipc.hook.0"
Successfully wrote action '#count-updates_ipc.hook.0' to PID 33971

Related Issues & Documents

/

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

@patrick96 patrick96 changed the base branch from master to hotfix/3.6.1 March 5, 2022 08:30
@patrick96 patrick96 added this to the 3.6.1 milestone Mar 5, 2022
@patrick96
Copy link
Member

Thanks for noticing :)

@patrick96 patrick96 merged commit 8820cc7 into polybar:hotfix/3.6.1 Mar 5, 2022
@nathanaelhoun nathanaelhoun deleted the fix-deprecated-polybar-msg-warning branch March 5, 2022 08:52
@patrick96 patrick96 mentioned this pull request Mar 5, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants