[module/bspwm] Option to scroll through occupied desktops only #2428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick96
requested changes
May 12, 2021
Member
patrick96
left a comment
There was a problem hiding this comment.
Thanks :)
Code looks solid. Just one small change, the default value of the setting should be false so that we don't change the behavior of existing configs.
Codecov Report
@@ Coverage Diff @@
## master #2428 +/- ##
=========================================
- Coverage 9.83% 9.83% -0.01%
=========================================
Files 147 147
Lines 10492 10495 +3
=========================================
Hits 1032 1032
- Misses 9460 9463 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
New config option 'occupied-scroll' for bspwm module that allows scrolling only occupied desktops.
Related Issues & Documents
Closes #2427
Documentation (check all applicable)
Update bspwm module wiki page