Add support for %nwin% in xworkspaces label #2329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2329 +/- ##
=========================================
- Coverage 7.80% 7.80% -0.01%
=========================================
Files 142 142
Lines 10340 10343 +3
=========================================
Hits 807 807
- Misses 9533 9536 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
patrick96
requested changes
Jan 3, 2021
Member
patrick96
left a comment
There was a problem hiding this comment.
Cool! 😃
Please resolve the merge conflicts and then we can merge this.
Thanks :)
%nwin% tells the number of windows in a workspace
5e0e902 to
ba20a71
Compare
patrick96
approved these changes
Jan 4, 2021
Member
patrick96
left a comment
There was a problem hiding this comment.
Looks good now.
Congrats on your first polybar contribution 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
In the xworkspace module, added %nwin% token to display the number of windows in a workspace. Affects the
label-active,label-occupied,label-urgentandlabel-emptyproperties.Related Issues & Documents
Closes #604
Documentation (check all applicable)
At the Modules: xworkspace page, add the %nwin% as an available token for
label-active,label-occupied,label-urgentandlabel-emptyproperties