feat(xworkspaces): List occupied workspaces #1429
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This covers more of an edge-case. I did this first by accident, it might vanish later on.
Because the index needs to be matched later on, type mismatches would be non-ideal.
This alone simplifies the management and the lookup for occupation of a workspace
Therefore we update the desktop-count tally every time the client_list changes. It may just be a desktop-change without a change of clients.size()...
…nto list-occupied-workspaces
Also, performance improvements when diffing new and old client lists
Codecov Report
@@ Coverage Diff @@
## master #1429 +/- ##
=========================================
- Coverage 5.83% 5.82% -0.01%
=========================================
Files 161 161
Lines 8935 8950 +15
=========================================
Hits 521 521
- Misses 8414 8429 +15
Continue to review full report at Codecov.
|
Contributor
|
may I cherry-pick your change into my PR, @swillner? Then the whole history is in one place. attribution should stay the same... |
Author
|
of course! just give me a ping and I'll close this PR. |
Contributor
There is no ping-emoji, but I can give you 🏓. Completely unrelated, I cherry-picked your fix and added it to the other PR. :-) |
Author
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues in #882