config_parser: Preparations #1352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can still run tests with some compiler warnings
This way warnings are colored differently from actual errors in vim
The sstream test was removed because it only tested standard library behvaior
Codecov Report
@@ Coverage Diff @@
## master #1352 +/- ##
=========================================
- Coverage 5.94% 5.83% -0.12%
=========================================
Files 161 161
Lines 8929 8929
=========================================
- Hits 531 521 -10
- Misses 8398 8408 +10
Continue to review full report at Codecov.
|
NBonaparte
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few commits made in #1237 that are not directly related to the config parser. I'd like to merge these before I start with the other PRs