refactor(battery): simplify animation subthread #1213
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for contributing. People in #568 also complained about uneven animations. I will review this and look into why the animations has some deeper issues. |
patrick96
requested changes
Jan 21, 2020
Member
patrick96
left a comment
There was a problem hiding this comment.
Seems I never did come around to digging deeper on the framerate issue, and so I also never looked at this again, sorry about that 😅
If you are still around, I have reviewed this now.
Maybe the uneven animation come from the fact that we don't use a steady clock (the PR for this is #1725).
| int framerate = 1000; // milliseconds | ||
| if (m_state == battery_module::state::CHARGING) { | ||
| broadcast(); | ||
| framerate = m_animation_charging->framerate(); |
Member
There was a problem hiding this comment.
m_animation_charging may be NULL
| framerate = m_animation_charging->framerate(); | ||
| } else if (m_state == battery_module::state::DISCHARGING) { | ||
| broadcast(); | ||
| framerate = m_animation_discharging->framerate(); |
Member
There was a problem hiding this comment.
m_animation_discharging may be NULL
Member
Contributor
Author
|
Closing in favor of #1683. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came up with this while trying to make the animations "smoother" => currently, it's skipping animation icons quite often due to timing issues on my machine. Haven't been able to improve animation smoothness, though, as it appears to be a deeper issues. In any case, the calls of
broadcast()appear to be timed correctly.