-
-
Notifications
You must be signed in to change notification settings - Fork 723
Closed
Description
Describe the issue
When splitting configuration into multiple files and loading them using include-file directives, the --reload flag only picks up changes at the top config level.
Expected behavior:
Polybar should also reload when any files referenced with include-file are changed,.
To Reproduce
The simplest way is to create an empty file and reference it from your polybar config, e.g.:
[settings]
margin-top = 0
margin-bottom = 0
include-file = ~/.config/polybar/extra.config
Whenever you run Polybar with --reload and then save changes to extra.config, Polybar should reload.
Additional context
The file system watchers are set in main.cpp:
Line 142 in 56e2499
| config_watch = inotify_util::make_watch(conf.filepath()); |
if (cli->has("reload")) {
config_watch = inotify_util::make_watch(conf.filepath());
}Fortunately this already happens after configuration is loaded, and it looks like a fairly straight-forward task to keep track of include-file calls and create a watcher for each one.
Metadata
Metadata
Assignees
Labels
No labels