Merged
Conversation
TarikGul
reviewed
Dec 8, 2025
TarikGul
approved these changes
Dec 8, 2025
Member
TarikGul
left a comment
There was a problem hiding this comment.
Looks fine, I would also mention that the cryptoAwaitReady and can work in conjunction with the non async stuff. Since most usecases might have multiple crypto imports.
rajk93
approved these changes
Dec 8, 2025
paulmillr
reviewed
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds comprehensive documentation for the sr25519 migration from WASM to pure JavaScript implementation (@scure/sr25519), corresponding to polkadot-js/common#1971.
🤔 Why This Documentation is Needed
The SR25519 migration represents a breaking change: