Add Optional Strict Input Checking to u8aToU8a#1994
Merged
ap211unitech merged 3 commits intomasterfrom Jun 30, 2025
Merged
Conversation
u8aToU8a
TarikGul
reviewed
Jun 24, 2025
TarikGul
previously approved these changes
Jun 24, 2025
valentinfernandez1
approved these changes
Jun 25, 2025
Contributor
valentinfernandez1
left a comment
There was a problem hiding this comment.
Awesome find 🔥
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR introduces an opt-in
strictparameter to theu8aToU8afunction to prevent silently convertingnullorundefinedinputs into emptyUint8Arrayinstances.💡 Motivation
While working with this function, we noticed that passing
nullorundefinedwas producing empty arrays instead of throwing errors, leading to hard-to-trace issues. This behavior caused 134 test failures. Instead of modifying every test and potentially introducing inconsistencies, we chose to add a strict checking mode.🔧 Changes
strictboolean parameter (default:false) tou8aToU8a.strictis enabled, the function throws an error if the input isnullorundefined.✅ Benefits
This approach allows developers to opt into stricter input validation when needed, reducing the chances of subtle bugs or random runtime issues in downstream applications.