Skip to content

Add Creditcoin3 support to Generic Ledger App#1985

Merged
ap211unitech merged 7 commits intopolkadot-js:masterfrom
gluwa:creditcoin-ledger
Jul 28, 2025
Merged

Add Creditcoin3 support to Generic Ledger App#1985
ap211unitech merged 7 commits intopolkadot-js:masterfrom
gluwa:creditcoin-ledger

Conversation

@rustlang-dev
Copy link
Copy Markdown
Contributor

@rustlang-dev rustlang-dev commented Apr 30, 2025

Add Creditcoin3 support to Generic Ledger App

@rustlang-dev rustlang-dev marked this pull request as draft April 30, 2025 10:53
@valentinfernandez1 valentinfernandez1 self-requested a review May 2, 2025 16:17
@valentinfernandez1
Copy link
Copy Markdown
Contributor

Are there any updated about this Draft PR?

@rustlang-dev rustlang-dev marked this pull request as ready for review May 7, 2025 11:04
@DylanVerstraete
Copy link
Copy Markdown

@valentinfernandez1 please check 👍 😄

Copy link
Copy Markdown
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Copy Markdown
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the early approval - believe inside of hw-ledger/src/defaults.ts creditcoin3 should be under genericLedgerApps instead

@TarikGul
Copy link
Copy Markdown
Member

Just needs a yarn lint

@beqaabu
Copy link
Copy Markdown
Contributor

beqaabu commented Jul 17, 2025

@TarikGul, we dont want to enable ledger support on mainnet before testing it on our testnet first, but the note in genesis.ts says:

// IMPORTANT: Apart from the test relays, this list is limited to live parachains
// and live production networks. It does not and should not contain any testnets,
// either stand-alone or connected to test relays such as Westend/Rococo

see the link: https://github.com/gluwa/common/blob/ab1d3c0b07bd79cf8aab937ad22e5df4b68e78ba/packages/networks/src/defaults/genesis.ts#L11-L13
We have made necessary changes on the protocol level to support ledger, but without the changes in this pr our ledger support page looks like this
image
instead of this
image
As you can see, there is no option to attach ledger, which is expected. Could you please suggest how we could achieve what we want without violating the note given above?

@beqaabu
Copy link
Copy Markdown
Contributor

beqaabu commented Jul 21, 2025

Hi @TarikGul @valentinfernandez1, could you please take a look?

@DylanVerstraete
Copy link
Copy Markdown

@TarikGul Can we get this moving please?

@TarikGul
Copy link
Copy Markdown
Member

Please refer to @ap211unitech @rajk93 @valentinfernandez1

@ap211unitech
Copy link
Copy Markdown
Member

Certainly...I'll review it soon.

Copy link
Copy Markdown
Member

@ap211unitech ap211unitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@ap211unitech ap211unitech merged commit 03c8169 into polkadot-js:master Jul 28, 2025
4 checks passed
@polkadot-js-bot
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jul 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants