Fix: add phantom export to prevent empty types.ts compilation error#6221
Merged
Fix: add phantom export to prevent empty types.ts compilation error#6221
types.ts compilation error#6221Conversation
TarikGul
approved these changes
Nov 10, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5566
Problem
When using typegen with definitions containing no custom types (only RPC/runtime definitions), the generated
types.tsfile would be completely empty, causing TypeScript compilation errors when re-exported viaexport * from './types'.Solution
Added a phantom export to the
tsDef/types.hbstemplate to ensure the generated file always has at least one export:While @jacogr mentioned #5566 (comment) using a timestamped phantom
export PHANTOM_GENERATED_<Date.now()>for uniqueness, but here a static phantom export is sufficient because: