Add transaction-payment runtime API V3 by notlesh · Pull Request #5430 · polkadot-js/api

notlesh · 2023-01-19T22:05:11Z

This PR is a companion for paritytech/substrate#13110. It adds the same API definitions to pallet-transaction-payment introduced there. The API version is being rev'ed from V2 -> V3.

I have not been able to get this to work and could use a pointer.

When run my local changes here against a node/runtime supporting the new V3, the entire api.call.transactionPaymentApi is missing (undefined), likely the same symptom described in the PR above. It seems to work fine for V2.

I think I need to run yarn polkadot-types-from-chain to generate some code and put it in the right place, but I'm not sure exactly how to invoke this. I could be barking up the wrong tree, of course.

jacogr · 2023-01-20T08:09:50Z

Weird, at quick glance it does add the right things. (The typegen is only needed for TS developers, so it doesn't need to be run)

How are you testing this against a local node? (Which steps?)

jacogr

Some small linting fixes on quotes, aka ' vs "

packages/types/src/interfaces/payment/runtime.ts

jacogr

Just spread into empty object (otherwise it would actually clobber the existing)

packages/types/src/interfaces/payment/runtime.ts

jacogr

Apply same "to-empty-spread" functionality for TransactionPaymentCallApi

packages/types/src/interfaces/payment/runtime.ts

jacogr · 2023-01-20T08:33:55Z

After applying the above locally and running against your node -

So seems fine.

packages/types/src/interfaces/payment/runtime.ts

notlesh · 2023-01-23T23:05:23Z

Thanks for the help, Jaco! I believe addressed the query_call_info issue, PTAL.

However, I haven't been able to set up an override for @polkadot.js/types to test this in any way. I've tried a few things but am really just shooting in the dark, is there some documentation on doing this? (I'm a typescript noob, btw).

jacogr · 2023-01-24T05:03:59Z

Depends on how you want to test. So for my tests above, I have this structure - <ROOT>/api and <ROOT>/apps (i.e. both repos in the same top-level)

Apply the changes in api
inside api I do a yarn polkadot-dev-copy-to apps (this compiles all and replaces the node_modules inside apps)
Inside apps, I do a yarn start
Play with apps UI on localhost:3000

So basically the polkadot-dev-copy-to command is useful to get stuff into other projects. (The first .. is assumed, but any depth can be achieved, for sanity just made it simple to assume the same top-level structure in those scripts)

notlesh · 2023-01-24T21:19:16Z

Thanks! I was able to test the changes, LGTM now!

jacogr

Looks all-ok. Will wait for the Substrate PR to be merged before merging this one (just in-case there are some changes required there)

ggwpez · 2023-01-26T14:39:58Z

Substrate just merged paritytech/substrate#13110

jacogr

Thank you.

polkadot-js-bot · 2023-01-29T07:18:24Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Add transaction-payment runtime API V3

1b45fed

notlesh mentioned this pull request Jan 19, 2023

Add WeightToFee and LengthToFee impls to transaction-payment Runtime API paritytech/substrate#13110

Merged