Merged
Conversation
Contributor
Author
|
It might also make sense to use |
Marking it as `visible` before adding it to the `AdwApplication` has the
negative side effect that things like `app_id` will be inferred from
defaults rather than from the application object.
This fixes e.g. the missing icon on phosh as the app-id is now correct:
```
$ WAYLAND_DEBUG=1 flatpak run com.pojtinger.felicitas.Sessions |& grep -i "xdg.*set_app_id"
[1660879.185] -> xdg_toplevel#64.set_app_id("com.pojtinger.felicitas.Sessions")
```
Closes: pojntfx#6
Signed-off-by: Guido Günther <agx@sigxcpu.org>
Owner
Owner
|
Tested this locally, looks all good to me: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marking it as
visiblebefore adding it to theAdwApplicationhas the negative side effect that things likeapp_idwill be inferred from defaults rather than from the application object.This fixes e.g. the missing icon on phosh as the app-id is now correct:
Closes: #6
Signed-off-by: Guido Günther agx@sigxcpu.org