Dev snapshot compare2#490
Closed
JWStaiert wants to merge 2 commits into
Closed
Conversation
Member
|
@JWStaiert Sorry for missing this README addition. We've finally moved forward with a fit that addresses the core problem by merging #628, so you may be able to retire your plug-in if you don't want to maintain it. Thanks for providing this solution to others in the meantime, though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just those changes needed to allow a package dependent on SnapshotTesting to define new strategies. I'm uncertain if this is what you had in mind when you asked me to refactor my SnapshotCompare code into a plug-in. Let me know and I will revise as necessary.
Changes include: making various structs public, updating README.md to contain a link to my strategy package.