Fix PHP Deprecated Warnings for REST API#7437
Merged
sc0ttkclark merged 3 commits intopods-framework:release/3.3.2from Jul 7, 2025
Merged
Fix PHP Deprecated Warnings for REST API#7437sc0ttkclark merged 3 commits intopods-framework:release/3.3.2from
sc0ttkclark merged 3 commits intopods-framework:release/3.3.2from
Conversation
2 tasks
f758366 to
e560bfc
Compare
PR Summary
|
e560bfc to
772336b
Compare
sc0ttkclark
previously approved these changes
Jul 7, 2025
sc0ttkclark
approved these changes
Jul 7, 2025
11bc821
into
pods-framework:release/3.3.2
9 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the
src/Pods/REST/V1/Endpoints/Base.phpfile to explicitly mark the parameters as nullable instead of implicitly, which is deprecated.Note that some additional testing would be appreciated with older PHP versions. I went with
?instead of|nullfor better backwards compatibility. This method should be supported in PHP 7.1 and above:https://www.php.net/manual/en/migration71.new-features.php
Related GitHub issue(s)
Partly fixes #7401 after this PR all that is left is to fix the vendor errors in the DI52 package
Testing instructions
Changelog text for these changes
Enhancement: Remove PHP Deprecation warnings for Pod's REST API. #7401 (@BrookeDot)
PR checklist