Skip to content

Pass array values only to prevent PHP8 named parameters#6013

Merged
sc0ttkclark merged 1 commit intorelease/2.7.28from
feature/6012-php8
May 11, 2021
Merged

Pass array values only to prevent PHP8 named parameters#6013
sc0ttkclark merged 1 commit intorelease/2.7.28from
feature/6012-php8

Conversation

@JoryHogeveen
Copy link
Copy Markdown
Member

@JoryHogeveen JoryHogeveen commented Apr 29, 2021

Description

https://wordpress.org/support/topic/php-8-debugging/

Related GitHub issue(s)

Fixes #6012 (Verified by user)

Changelog text for these changes

PR checklist

@JoryHogeveen JoryHogeveen self-assigned this Apr 29, 2021
@JoryHogeveen JoryHogeveen added Status: PR > Pending Code Review PR is pending code review by core developers Status: PR > QA pass QA passed Type: Bug labels Apr 29, 2021
@JoryHogeveen JoryHogeveen added this to the Pods 2.7.28 milestone Apr 29, 2021
@marcdegagne
Copy link
Copy Markdown

Hello Jory,

Marc De Gagné from LOB ( Pods user from WP Pods support).

Just to mark it as tested on my side in your GIT flow.
Tested on PHP 7.4 and 8.0. Both working with the change.
Since this was only a one liner on one class, I did the test with just hard coding the change in the Pods.php class.

Thanks

@sc0ttkclark sc0ttkclark changed the base branch from main to release/2.7.28 May 11, 2021 18:15
@sc0ttkclark sc0ttkclark added Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) and removed Status: PR > Pending Code Review PR is pending code review by core developers labels May 11, 2021
@sc0ttkclark sc0ttkclark merged commit 2c474fd into release/2.7.28 May 11, 2021
@sc0ttkclark sc0ttkclark deleted the feature/6012-php8 branch May 11, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: PR > QA pass QA passed Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP 8: Fatal error: Uncaught Error: Unknown named parameter

3 participants