Rework devices from path#28060
Conversation
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
This still includes the commits from #28008. I will rebase and rework as soon as that's merged. |
bc6e60c to
dc09a0c
Compare
96f29d8 to
f7fc240
Compare
Honny1
left a comment
There was a problem hiding this comment.
Hi, I’ve done a light review and the code looks good. However, I’d like to ask you to add some unit tests. Since this is a rework, there shouldn't be any behavioral changes; if you feel that testing this would be redundant, it isn't a strict requirement. That said, could you please resolve the TODOs in your code?
Signed-off-by: Evan Lezar <elezar@nvidia.com>
f7fc240 to
d83de09
Compare
This changes how container.conf and host_device_list CDI devices are handled. Instead of injecting these separately (requiring) separate instatiations of a CDI cache, these are pre-processed to extract the list of CDI device names. These CDI devices are then added to the list of CDI devices names from explicit --device requests and implicit requests from the --gpus flag. Signed-off-by: Evan Lezar <elezar@nvidia.com>
d83de09 to
a1feabf
Compare
|
@elezar, can you please rebase on main? Thanks. |
Yes. I will spend some cycles on this as I also need to address your last comment w.r.t adding tests. |
This PR is a response to https://github.com/containers/podman/pull/28008/changes#r2787912757
This changes how container.conf and host_device_list CDI devices
are handled. Instead of injecting these separately (requiring)
separate instatiations of a CDI cache, these are pre-processed to
extract the list of CDI device names. These CDI devices are then
added to the list of CDI devices names from explicit --device requests
and implicit requests from the --gpus flag.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?