libpod: don't force only network search domains#26221
Merged
openshift-merge-bot[bot] merged 3 commits intoJun 4, 2025
Merged
Conversation
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
This was referenced May 28, 2025
Contains the resolv.conf setup changes. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
We like to append the host servers in that case so that we do not only force dns.podman. Fixes: podman-container-tools#24713 Fixes: https://issues.redhat.com/browse/RHEL-83787 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
We should fully replace the options, now that we vendored the libnetwork/resolvconf changes into podman this just works. Fixes: podman-container-tools#22399 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Member
Author
|
@containers/podman-maintainers PTAL |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mtrmac
reviewed
Jun 3, 2025
mtrmac
left a comment
Contributor
There was a problem hiding this comment.
LGTM otherwise, please merge without another review round.
/lgtm
/hold
| Expect(session).Should(ExitCleanly()) | ||
|
|
||
| session = podmanTest.Podman([]string{"run", "--name", "con1", "--network", net, CITEST_IMAGE, "nslookup", "con1"}) | ||
| // Note apline nslookup tries to resolve all search domains always and returns an error if one does not resolve. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Note apline nslookup tries to resolve all search domains always and returns an error if one does not resolve. | |
| // Note alpine nslookup tries to resolve all search domains always and returns an error if one does not resolve. |
Member
Author
|
/hold cancel |
4030ee6
into
podman-container-tools:main
84 of 85 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We like to append the host servers in that case so that we do not only
force dns.podman.
Fixes: #24713
Fixes: https://issues.redhat.com/browse/RHEL-83787
Also:
We should fully replace the options, now that we vendored the
libnetwork/resolvconf changes into podman this just works.
Fixes: #22399
Does this PR introduce a user-facing change?