Skip to content

vendor: update to latest c/common#25840

Merged
openshift-merge-bot[bot] merged 2 commits into
podman-container-tools:mainfrom
Luap99:list-manifest
Apr 14, 2025
Merged

vendor: update to latest c/common#25840
openshift-merge-bot[bot] merged 2 commits into
podman-container-tools:mainfrom
Luap99:list-manifest

Conversation

@Luap99

@Luap99 Luap99 commented Apr 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes a flake in the system tests during image listing.
Also fixes a flake during podman stats listing.

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 9, 2025
@Luap99 Luap99 mentioned this pull request Apr 9, 2025
Merged
@packit-as-a-service

packit-as-a-service Bot commented Apr 9, 2025

Copy link
Copy Markdown

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@openshift-ci openshift-ci Bot added release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Apr 10, 2025
@Luap99 Luap99 changed the title DNM: test c/common chnages vendor: update to latest c/common Apr 10, 2025
@Luap99 Luap99 marked this pull request as ready for review April 10, 2025 11:03
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2025
Luap99 added 2 commits April 11, 2025 17:17
@Luap99
vendor: update to latest c/common
86d7da8 
Fixes a flake in the system tests during image listing.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99
libpod: stats catch ErrStatCgroup
d3e2ca5 
Stat() actually ignored ENOENT errors so there is no point in matching
them, instead of Stat() does not find a valid cgroup file it returns
ErrStatCgroup so match that instead.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99 Luap99 added the No New Tests Allow PR to proceed without adding regression tests label Apr 11, 2025
giuseppe
giuseppe approved these changes Apr 14, 2025
View reviewed changes

@giuseppe giuseppe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci

openshift-ci Bot commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99

Luap99 commented Apr 14, 2025

Copy link
Copy Markdown
Member Author

@containers/podman-maintainers PTAL

mtrmac
mtrmac reviewed Apr 14, 2025
View reviewed changes

@mtrmac mtrmac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit f64204f into podman-container-tools:main Apr 14, 2025
@Luap99 Luap99 deleted the list-manifest branch April 14, 2025 13:48
@stale-locking-app stale-locking-app Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jul 14, 2025
@stale-locking-app stale-locking-app Bot locked as resolved and limited conversation to collaborators Jul 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mtrmac mtrmac mtrmac left review comments

@giuseppe giuseppe giuseppe approved these changes

Assignees

@mtrmac mtrmac

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. No New Tests Allow PR to proceed without adding regression tests release-note-none

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Luap99 @giuseppe @mtrmac