Skip to content

Mask thermal paths#25635

Merged
openshift-merge-bot[bot] merged 1 commit into
podman-container-tools:mainfrom
giuseppe:mask-thermal-paths
Mar 21, 2025
Merged

Mask thermal paths#25635
openshift-merge-bot[bot] merged 1 commit into
podman-container-tools:mainfrom
giuseppe:mask-thermal-paths

Conversation

@giuseppe

@giuseppe giuseppe commented Mar 20, 2025

Copy link
Copy Markdown
Contributor

Mask /proc/interrupts and /sys/devices/system/cpu//thermal_throttle by default

vendor the following dependencies:

Closes: #25634

Does this PR introduce a user-facing change?

Mask /proc/interrupts and /sys/devices/system/cpu//thermal_throttle by default

@giuseppe giuseppe added the No New Tests Allow PR to proceed without adding regression tests label Mar 20, 2025
@openshift-ci openshift-ci Bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 20, 2025
@giuseppe giuseppe marked this pull request as draft March 20, 2025 13:26
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2025
@giuseppe giuseppe force-pushed the mask-thermal-paths branch from 9d63675 to c281e69 Compare March 20, 2025 13:55
@giuseppe giuseppe added the bloat_approved Approve a PR in which binary file size grows by over 50k label Mar 20, 2025
@giuseppe giuseppe force-pushed the mask-thermal-paths branch from c281e69 to 6305eaf Compare March 20, 2025 15:06
@Honny1

Honny1 commented Mar 20, 2025

Copy link
Copy Markdown
Contributor

This PR vendors new feature of Buildah supports of COPY --parents in Containerfile.

@giuseppe giuseppe force-pushed the mask-thermal-paths branch from 6305eaf to 5bbcafa Compare March 21, 2025 13:03
@mheon

mheon commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

Should this still be WIP? c/common is merged, no?

vendor the following dependencies:

- containers/common#2375
- podman-container-tools/buildah#6074

Closes: podman-container-tools#25634

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the mask-thermal-paths branch from 5bbcafa to 260035d Compare March 21, 2025 13:36
@giuseppe

Copy link
Copy Markdown
Contributor Author

Should this still be WIP? c/common is merged, no?

no, not a WIP, just waiting for the CI to be green before asking for a review

@giuseppe giuseppe marked this pull request as ready for review March 21, 2025 14:12
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2025
@giuseppe

Copy link
Copy Markdown
Contributor Author

green enough :)

@giuseppe giuseppe changed the title vendor: test new common and buildah Mask thermal paths Mar 21, 2025

@Luap99 Luap99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2025
@openshift-ci

openshift-ci Bot commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 7d3ee5a into podman-container-tools:main Mar 21, 2025
@stale-locking-app stale-locking-app Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jun 20, 2025
@stale-locking-app stale-locking-app Bot locked as resolved and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bloat_approved Approve a PR in which binary file size grows by over 50k lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. No New Tests Allow PR to proceed without adding regression tests release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mask Linux thermal interrupt info in /proc and /sys

4 participants