Skip to content

[WIP] Verify images in manifest list are not dangling and pruned#25562

Closed
rhatdan wants to merge 1 commit into
podman-container-tools:mainfrom
rhatdan:dangling
Closed

[WIP] Verify images in manifest list are not dangling and pruned#25562
rhatdan wants to merge 1 commit into
podman-container-tools:mainfrom
rhatdan:dangling

Conversation

@rhatdan

@rhatdan rhatdan commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

Vendor in latest containers/common

Currently if you create an un tagged image and add it to a manifest list, podman image prune will remove the image, and leave you with a broken manifest list. This PR removes the image from dangling in this situation and prevents the pruning.

We have seen this trigger issues with RamaLama which is creating manifest lists in this manner, and then users pruning the images.

Verifing: containers/common#2360

Does this PR introduce a user-facing change?

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2025
@openshift-ci

openshift-ci Bot commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Mar 12, 2025
@rhatdan rhatdan mentioned this pull request Mar 12, 2025
Merged
@openshift-ci

openshift-ci Bot commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2025
@packit-as-a-service

packit-as-a-service Bot commented Mar 12, 2025

Copy link
Copy Markdown

Cockpit tests failed for commit 4c2d198. @martinpitt, @jelly, @mvollmer please check.

@martinpitt

martinpitt commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

Wrt. cockpit tests: The log shows a crash on podman rmi localhost/test-hello:latest. The full trace is huge, it starts with this:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x5586e472b513]

goroutine 1 gp=0xc000002380 m=7 mp=0xc00043e008 [running]:
panic({0x5586e5567600?, 0x5586e654fac0?})
	/usr/lib/golang/src/runtime/panic.go:806 +0x168 fp=0xc0004c30e0 sp=0xc0004c3030 pc=0x5586e3aa29a8

As your tests don't fail other than this "tree is dirty, please run 'make vendor'" in postinstall, please let me know if you need help with reproducing. But as this is still "WIP", I won't spend much time on this for now.

@github-actions github-actions Bot added the kind/api-change Change to remote API; merits scrutiny label Mar 18, 2025
@packit-as-a-service

packit-as-a-service Bot commented Mar 18, 2025

Copy link
Copy Markdown

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@rhatdan
Verify images in manifest list are not dangling and pruned
bb35c30 
Vendor in latest containers/common

Currently if you create an un tagged image and add it to a manifest
list, podman image prune will remove the image, and leave you with
a broken manifest list. This PR removes the image from dangling in
this situation and prevents the pruning.

We have seen this trigger issues with RamaLama which is creating
manifest lists in this manner, and then users pruning the images.

Verifing: containers/common#2360

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2025
@openshift-merge-robot

openshift-merge-robot commented Mar 25, 2025

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions

github-actions Bot commented Apr 25, 2025

Copy link
Copy Markdown

A friendly reminder that this PR had no activity for 30 days.

@rhatdan rhatdan closed this Sep 25, 2025
@stale-locking-app stale-locking-app Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 25, 2025
@stale-locking-app stale-locking-app Bot locked as resolved and limited conversation to collaborators Dec 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Change to remote API; merits scrutiny locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. stale-pr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhatdan @martinpitt @openshift-merge-robot