Skip to content

vendor latest c/common to fix rootless-netns issues#22243

Merged
openshift-merge-bot[bot] merged 2 commits into
podman-container-tools:mainfrom
Luap99:rootless-netns
Apr 4, 2024
Merged

vendor latest c/common to fix rootless-netns issues#22243
openshift-merge-bot[bot] merged 2 commits into
podman-container-tools:mainfrom
Luap99:rootless-netns

Conversation

@Luap99

@Luap99 Luap99 commented Apr 2, 2024

Copy link
Copy Markdown
Member

Does this PR introduce a user-facing change?

Fixed some problems when using custom networks as rootless user.

@Luap99 Luap99 added the No New Tests Allow PR to proceed without adding regression tests label Apr 2, 2024
@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 2, 2024
Luap99 added 2 commits April 3, 2024 15:01
Includes several rootless-netns fixes.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This is a test for podman-container-tools#22168.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99 Luap99 marked this pull request as ready for review April 3, 2024 13:02
@Luap99 Luap99 removed the No New Tests Allow PR to proceed without adding regression tests label Apr 3, 2024
@Luap99 Luap99 changed the title WIP: test rootless-netns fixes from c/common vendor latest c/common to fix rootless-netns issues Apr 3, 2024
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2024
@Luap99

Luap99 commented Apr 4, 2024

Copy link
Copy Markdown
Member Author

@containers/podman-maintainers PTAL

@giuseppe giuseppe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci

openshift-ci Bot commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan

rhatdan commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit 8ab4bc9 into podman-container-tools:main Apr 4, 2024
@Luap99 Luap99 deleted the rootless-netns branch April 4, 2024 11:59
@stale-locking-app stale-locking-app Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jul 4, 2024
@stale-locking-app stale-locking-app Bot locked as resolved and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Podman info has become slower again, when running on ubuntu or debian

3 participants