docs: Clarify that container signatures expect a single signature packet#426
Merged
mtrmac merged 1 commit intoOct 31, 2025
Merged
Conversation
2f7e230 to
c5c2dfa
Compare
TomSweeneyRedHat
left a comment
Contributor
There was a problem hiding this comment.
LGTM
@mtrmac PTAL
mtrmac
reviewed
Oct 30, 2025
mtrmac
left a comment
Contributor
There was a problem hiding this comment.
Sure, makes sense to clarify this.
| (e.g. it MUST NOT be an unsigned “Literal Message”, | ||
| a “Cleartext Signature” as defined in RFC 4880 section 7, | ||
| or any other non-signature format). | ||
| - The blob MUST contain one single "Signature Packet" as defined in RFC 4880 section 5.2. |
Contributor
There was a problem hiding this comment.
‘must not contain multiple ”Signature Packet”s’, to be unambiguous?
As a non-native speaker, I don’t read “must contain one” to prohibit “must not contain two”; the “single” sort of does imply uniqueness, but that kind of grammar is not taught in introductory English courses.
Clarify that OpenPGP container signatures are expected to contain exactly one signature packet. This clarification is necessary because, according to RFC 4880, a "Signed Message" may contain a sequence of signature packets. This case might not be correctly handled by the existing verification software. Signed-off-by: Roberto Hueso Gomez <roberto@robertohueso.org>
c5c2dfa to
6a39ff0
Compare
mtrmac
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that OpenPGP container signatures are expected to contain a single signature packet.
This clarification is necessary because, according to RFC 4880, a "Signed Message" may contain a sequence of signature packets. This case might not be correctly handled by the existing verification software.
More info on this on this PR in #423