Re-enable vendoring#410
Conversation
|
This is an example of Renovate PR opened in my fork with this PR applied: jankaluza#2 |
|
Second commit skips the codespell for the |
Luap99
left a comment
There was a problem hiding this comment.
Need to update the Makefiles to rename tidy to vendor and do the go work vendor step in the Makefiles and I guess we want the go work sync as well added to the top level Makefile. And then update the go-tidy github action to run the make vendor instead
|
@Luap99 , done in the third commit. I also renamed the tidy-in-container to vendor-in-container, but I did not find any place where this is executed - probably only manually? |
mtrmac
left a comment
There was a problem hiding this comment.
Thanks, makes sense overall.
(For the record, AFAICT we need the vendor step because Renovate only does go work sync if vendoring is enabled, per #291 (comment) .)
The Renovate PR to support top-level vendor directory is merged and should be deployed in the production. It should be safe to re-enable the vendoring now. Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
We do not want to check the spelling in the code we do not own. Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
And also run the `go work sync` in the end of the main Makefile. Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
83aaec1 to
af0fbec
Compare
Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
|
I also had to disable the |
The Renovate PR to support top-level vendor directory is merged and should be deployed in the production.
It should be safe to re-enable the vendoring now.