fix(Foundation): add missing <limits> include in SharedMemory_WIN32#5248
Merged
fix(Foundation): add missing <limits> include in SharedMemory_WIN32#5248
Conversation
…5176) std::numeric_limits<DWORD> is used in the Win32 path but <limits> was never included directly, causing build failures when cross-compiling from Linux (e.g. MinGW on Debian 12) where the header is not pulled in transitively. Also use explicit null-pointer comparisons for HANDLE/LPVOID checks.
8797b74 to
feedfb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#include <limits>toSharedMemory_WIN32.cpp, fixing cross-compilation failures from Linux (e.g. MinGW on Debian 12) where the header is not pulled in transitivelyHANDLE/LPVOIDchecksCloses #5176