Skip to content

Extract and upgrade cpptrace from Trace/ to dependencies/#5219

Merged
matejk merged 1 commit intomainfrom
extract-and-upgrade-cpptrace
Feb 25, 2026
Merged

Extract and upgrade cpptrace from Trace/ to dependencies/#5219
matejk merged 1 commit intomainfrom
extract-and-upgrade-cpptrace

Conversation

@matejk
Copy link
Copy Markdown
Contributor

@matejk matejk commented Feb 23, 2026

Summary

  • Replace the vendored cpptrace (~v0.6.x, modified) in Trace/ with a clean copy of upstream cpptrace v1.0.4, placed under dependencies/cpptrace/ following the established bundled dependency pattern
  • Build cpptrace as OBJECT EXCLUDE_FROM_ALL (like zlib, pcre2, utf8proc); Foundation links it directly via BUILD_LOCAL_INTERFACE
  • Remove the Trace/ component entirely — it was only a thin wrapper around cpptrace used solely by Foundation/src/Exception.cpp
  • Update both CMake and Makefile build systems, dependency status printout, stage copies, and components file

Test plan

  • CMake build with ENABLE_TRACE=ON: Foundation builds, trace sample produces correct stack traces
  • CMake build without trace (default): clean build, no cpptrace references
  • Foundation test suite passes (100%) with trace enabled
  • Makefile build with ./configure --trace && make Foundation-libexec
  • CI passes on Linux, macOS, Windows

@matejk matejk requested a review from aleks-f February 23, 2026 10:13
@matejk matejk force-pushed the extract-and-upgrade-cpptrace branch from dc79f04 to ad058cf Compare February 23, 2026 10:36
…dependencies/

chore(Make): Allow build but issue a warning.
@matejk matejk force-pushed the extract-and-upgrade-cpptrace branch from ad058cf to 2090763 Compare February 23, 2026 14:43
@matejk matejk merged commit 8ff9a7f into main Feb 25, 2026
147 of 148 checks passed
@matejk matejk deleted the extract-and-upgrade-cpptrace branch February 25, 2026 08:30
@matejk matejk added this to the Release 1.15.1 milestone Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants