Extract and upgrade cpptrace from Trace/ to dependencies/#5219
Merged
Conversation
dc79f04 to
ad058cf
Compare
…dependencies/ chore(Make): Allow build but issue a warning.
ad058cf to
2090763
Compare
aleks-f
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trace/with a clean copy of upstream cpptrace v1.0.4, placed underdependencies/cpptrace/following the established bundled dependency patternOBJECT EXCLUDE_FROM_ALL(like zlib, pcre2, utf8proc); Foundation links it directly viaBUILD_LOCAL_INTERFACETrace/component entirely — it was only a thin wrapper around cpptrace used solely byFoundation/src/Exception.cppcomponentsfileTest plan
ENABLE_TRACE=ON: Foundation builds, trace sample produces correct stack traces./configure --trace && make Foundation-libexec