Fix ProcessRunner::start() to handle Windows executables without .exe extension#5180
Merged
Fix ProcessRunner::start() to handle Windows executables without .exe extension#5180
Conversation
6edec53 to
cb188d4
Compare
cb188d4 to
37019ef
Compare
4af7213 to
57459a6
Compare
Member
|
@matejk appending A file named |
Contributor
Author
|
You are right. I'll prepare proper implementation. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
File::getExecutablePath()method that returns the executable path (appends.exeon Windows if no extension present)ProcessRunner::start()to usegetExecutablePath()before checking file existencegetExecutablePath()Test plan
getExecutablePath()returns correct paths on Unix (unchanged) and Windows (.exeappended)