fix(Foundation): resolve Poco::format ambiguity with std::format in C++23#5170
Merged
fix(Foundation): resolve Poco::format ambiguity with std::format in C++23#5170
Conversation
b971028 to
ffbb089
Compare
ffbb089 to
a6f9161
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4966 - Resolves compilation error when using Poco::format with C++23 and std::format.
Problem
When compiling with C++23 and including both
Poco/Format.hand the standard<format>header (either directly or transitively), the compiler encounters ambiguity betweenPoco::formatandstd::formatfunctions.This issue is particularly evident when:
The ambiguity occurs in the
formatAny()helper functions which callformat()without explicit namespace qualification, allowing ADL (Argument-Dependent Lookup) to consider bothPoco::formatandstd::formatas candidates.Solution
Use explicit global namespace qualification (
::Poco::format) in theformatAny()helper functions to ensure onlyPoco::formatis considered, eliminating the ambiguity withstd::format.Changes
Foundation/include/Poco/Format.h:Poco::format()to::Poco::format()in bothformatAny()inline functionsTesting
<format>andPoco/Format.h