fix(Foundation): Adjust standard header inclusion logic for VS2022 clang-cl compatibility#5165
Merged
matejk merged 1 commit intopocoproject:mainfrom Jan 15, 2026
Merged
Conversation
…ang-cl compatibility Move <typeinfo> and <cstdlib> out of the POCO_HAVE_CXXABI_H conditional block — these are core C++ standard library headers and should not be tied to CXXABI detection logic. Compilation with clang-cl (Visual Studio 2022) failed due to an undefined POCO_HAVE_CXXABI_H macro, which led to missing <typeinfo> inclusion and subsequent "incomplete type 'const type_info'" errors. This change decouples standard headers from CXXABI checks to resolve the VS2022 clang-cl build issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move and out of the POCO_HAVE_CXXABI_H conditional block — these are core C++ standard library headers and should not be tied to CXXABI detection logic.
Compilation with clang-cl (Visual Studio 2022) failed due to an undefined POCO_HAVE_CXXABI_H macro, which led to missing inclusion and subsequent "incomplete type 'const type_info'" errors. This change decouples standard headers from CXXABI checks to resolve the VS2022 clang-cl build issue.