Skip to content

fix: Move bundled dependency symlinks to library-specific .gitignore files #5048#5138

Merged
matejk merged 1 commit intomainfrom
5048-fix-gitignore-for-bundled-dependencies
Dec 23, 2025
Merged

fix: Move bundled dependency symlinks to library-specific .gitignore files #5048#5138
matejk merged 1 commit intomainfrom
5048-fix-gitignore-for-bundled-dependencies

Conversation

@matejk
Copy link
Copy Markdown
Contributor

@matejk matejk commented Dec 23, 2025

Summary

Reorganizes .gitignore entries for bundled dependency symlinks from the root file into library-specific .gitignore files, and adds missing entries for PDF and Net libraries.

Changes

New library-specific .gitignore files created:

Library File Bundled Dependencies
Foundation Foundation/.gitignore zlib, pcre2, utf8proc
XML XML/.gitignore expat
JSON JSON/.gitignore pdjson
Data/SQLite Data/SQLite/.gitignore sqlite3
PDF PDF/.gitignore zlib, libpng, libharu (hpdf)
Net Net/.gitignore wepoll (MinGW only)

Root .gitignore cleanup:

Removed 55 lines of bundled dependency symlink entries that are now managed in their respective library subdirectories.

Key improvements

  1. PDF/src symlinks were completely missing - png and hpdf files created by prebuild step are now properly ignored
  2. Net/src/wepoll.c was missing - symlink for MinGW builds is now properly ignored
  3. Better organization - each library manages its own bundled dependency symlinks
  4. Maintainability - easier to update when dependencies change

Related

Closes #5048

@matejk matejk merged commit 38eb412 into main Dec 23, 2025
86 of 90 checks passed
@matejk matejk deleted the 5048-fix-gitignore-for-bundled-dependencies branch December 23, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt makefiles for external dependencies

1 participant