Summary

Fixes #4977

This PR addresses flaky Foundation tests that were failing intermittently on slower/loaded systems (e.g., nixpkgs builds) due to tight timing tolerances with fixed Thread::sleep() calls.

Changes

• Added waitForCondition() helper function to CppUnit for condition-based polling with timeout
• Replaced fixed Thread::sleep() calls with condition-based waiting in Foundation tests
• Converted unbounded while (...) Thread::sleep() loops to bounded waits that fail cleanly on timeout

Files Modified

Pattern Applied

// Before (unbounded, can hang forever):
while (condition) Thread::sleep(50);

// After (bounded, fails cleanly if condition never met):
assertTrue(waitForCondition([&]{ return condition; }, 5000));

waitForCondition API

template <typename Func>
bool waitForCondition(Func condition, long timeoutMs, long pollIntervalMs = 100)

• Polls condition every 100ms (configurable)
• Returns true if condition met, false on timeout
• Uses pure C++17 (std::chrono::steady_clock, std::this_thread::sleep_for)

Future Improvements: Net Library

The Net testsuite has similar patterns that could benefit from waitForCondition:

High Priority (Unbounded Loops)

Medium Priority (Fixed Sleeps + Assertions)

Total: ~49 Thread::sleep calls across 13 files, of which 2 are critical unbounded loops and ~8-10 are good candidates for condition-based waiting.

Test Plan

• All 69 modified Foundation tests pass
• Tests now fail cleanly with timeout instead of hanging forever
• CI validation