fix: Resolve compiler warnings and fix potential bugs#5130
Merged
Conversation
aleks-f
requested changes
Dec 22, 2025
Update third-party Tessil/ordered-map library from outdated version to v1.2.0 (November 2018). Changes from upstream: - Fix -Wdeprecated-copy warning by adding explicit default copy/move assignment operators - Bug fixes for insert_at_position and erase methods - Added erase_if function and contains() methods - Better GCC 9+ compatibility - Serialization support Source: https://github.com/Tessil/ordered-map/releases/tag/v1.2.0
67c7a6c to
af894ec
Compare
ecabb2c to
15ba8ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive compiler warning fixes across GCC, Clang (macOS), and MSVC builds.
Critical Bug Fixes
1. RegularExpression.cpp - PCRE2 Unset Match Detection
Check for unset capture groups was ALWAYS FALSE (
ovec[0] < 0on unsigned type).2. ProcessRunner.h - Windows Invalid PID Value
INVALID_PID = -1is wrong on Windows where PIDs are unsigned and 0 indicates invalid.3. ProcessRunner.cpp - PID Type Mismatch
PID file parsing used
intinstead of platform-specificPIDtype.4. IPAddressImpl.cpp - Missing Base Class Initialization
Copy constructors didn't explicitly initialize
RefCountedObjectbase class.5. X509Certificate.cpp - Variable Shadowing
Inner loop iterator shadowed outer loop iterator.
6. NumericString.h
safeMultiply- Overflow DetectionOverflow detection comparisons could give wrong results with mixed signed/unsigned types.
7. CppUnit TestCase.h - Test Assertions
assertEqualscould give incorrect results comparing signed vs unsigned values.Other Changes
-Wdeprecated-copy)constexprnull handle constants to avoid-Wzero-as-null-pointer-constantPOCO_DEPRECATEDand migration docs for Observer classCompiler Coverage
Test plan