fix(Data/PostgreSQL): Map UUIDOID to FDT_UUID instead of FDT_BLOB#5113
Merged
fix(Data/PostgreSQL): Map UUIDOID to FDT_UUID instead of FDT_BLOB#5113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix PostgreSQL UUID column type mapping so that UUID columns are properly recognized and can be converted to
Poco::UUID.Problem
In
PostgreSQLTypes.cpp,UUIDOIDwas incorrectly mapped toFDT_BLOB, causing UUID columns to be treated asPoco::Data::LOB<unsigned char>instead ofPoco::UUID.This prevented users from using
recordset.value("uuid").convert<Poco::UUID>()on PostgreSQL UUID columns.Solution
Change the mapping from
FDT_BLOBtoFDT_UUID. The extractors (Extractor.cpp,BinaryExtractor.cpp) already have proper UUID extraction support forUUIDOID.Fixes #4924