fix(Net): Detect incomplete chunked transfer encoding#5112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When receiving data with chunked transfer encoding, if the connection is closed by the peer without sending the terminating
0\r\n\r\n, or if a chunk is not sent completely,HTTPChunkedInputStreamnow sets aMessageExceptionthat can be retrieved viasession.networkException().Problem
Previously, when a server closed the connection gracefully (FIN) before completing the chunked response:
session.networkException()returnednullptrThis only occurred with graceful close (FIN). Connection reset (RST) already raised an exception properly.
Solution
Modified
HTTPChunkedStreamBuf::readFromDevice()to detect premature connection closure in two scenarios:read()returns 0 or less while expecting more data (_chunk > 0)In both cases, a
MessageException("Incomplete chunked transfer encoding")is now set via_session.setException().Testing
The fix can be tested using the reproduction steps from issue #5032. After the fix,
session.networkException()will return theMessageExceptionwhen the connection is closed before receiving the complete chunked response.Fixes #5032