enh(Crypto,NetSSL): Drop support for OpenSSL < 1.1.1#5108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes all compatibility code for OpenSSL versions prior to 1.1.1, significantly simplifying the codebase.
Closes #3739
Changes
CMake Requirements
find_package()callsCrypto Library
Crypto.hto require OpenSSL 1.1.1CRYPTO_set_locking_callback)EVP_CIPHER_CTXhandling to use pointer-based API only (removed stack allocation path)RSA_get0_key()usage (removed manual BIGNUM access)ASN1_STRING_get0_data,X509_get0_notBefore/notAfter,X509_up_ref, andX509_get_signature_nidNetSSL_OpenSSL Library
TLS_method()/TLS_client_method()/TLS_server_method()only. Simplified ECDH initialization and security level functionsMutex.hinclude (previously transitive through OpenSSLInitializer.h)Rationale
OpenSSL 1.1.1 reached end-of-life on 2023-09-11. All actively maintained systems should have at least this version available. The 1.1.x series introduced significant API changes that required extensive version conditionals in the codebase. Removing this legacy support: