fix(Net): Dispatch ErrorNotification to socket-specific handler only#5106
Merged
fix(Net): Dispatch ErrorNotification to socket-specific handler only#5106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an exception occurs during socket event processing in
SocketReactor::run(),onError(socket, ...)is called with the specific socket that caused the error. However, the error notification was being dispatched to ALL registered handlers instead of only the handler for that socket.This fix changes
onError(const Socket& socket, ...)to calldispatch(socket, notification)instead ofdispatch(notification), ensuring the error is routed only to the relevant socket's observer.Closes #4976