fix(Net): Use MessageHeader::quote() for boundary in HTMLForm#5100
Merged
fix(Net): Use MessageHeader::quote() for boundary in HTMLForm#5100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HTMLForm was unconditionally quoting the boundary parameter in Content-Type headers:
While technically RFC-compliant, this was inconsistent with other parts of the codebase and caused issues with strict parsers like nginx-upload-module.
Root Cause
Internal inconsistency in Poco:
MailMessageusesMediaType::toString()→MessageHeader::quote()(conditional quoting)HTMLFormused manual unconditional quotingSolution
Changed HTMLForm to use
MessageHeader::quote(), which only adds quotes when the value contains special characters. SinceMultipartWriter::createBoundary()generates boundaries likeMIME_boundary_A1B2C3D4E5F6G7H8(alphanumeric + underscore only), quotes are no longer added.RFC 2046 Compliance
Per RFC 2046 Section 5.1, quotes are only required when boundary contains non-alphanumeric characters other than
.,_,-.Benefits
Replaces #4953