fix: Resolve compiler warnings in Net, Zip, and Foundation modules#5092
Merged
fix: Resolve compiler warnings in Net, Zip, and Foundation modules#5092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes compiler warnings reported by modern C++ compilers (GCC 11+, Clang 15+):
Net module
(void)casts to suppress-Wunused-resultwarnings forread()andwrite()calls where return values are intentionally ignored (as documented in comments)-Wdeprecated-enum-enum-conversionby casting enum values tointbefore arithmetic operations betweenFacilityandSeverityenums-Wdeprecated-enum-enum-conversionby castingFrameFlagsandFrameOpcodesenum values tointbefore bitwise OR operationZip module
-Wdeprecated-anon-enum-enum-conversionby casting anonymous enum values tostd::size_torstd::streamsizewhen performing arithmetic withZipCommon::HEADER_SIZEFoundation module
std::atomic<int>(C++11) instead of deprecatedvolatile intwith complex#ifdef __cpp_lib_atomic_reffallback. This eliminates-Wdeprecated-volatilewarnings while maintaining thread-safe semanticsCI
macos-clang-cmake-warningsjob to detect compiler warnings in future buildsWarning Types Fixed
-Wunused-resultwarn_unused_resultattribute-Wdeprecated-enum-enum-conversion-Wdeprecated-anon-enum-enum-conversion-Wdeprecated-volatile