fix(Net): Add POCO_HAS_UNIX_SOCKET guards to fix build without Unix sockets #5064#5089
Merged
fix(Net): Add POCO_HAS_UNIX_SOCKET guards to fix build without Unix sockets #5064#5089
Conversation
916e690 to
220ed54
Compare
Contributor
Author
|
Updated: Changed item 6 - instead of simplifying the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
POCO_HAS_UNIX_SOCKETis not defined (e.g., older Windows SDKs lackingafunix.h, or whenPOCO_NET_NO_UNIX_SOCKETis explicitly defined), the build failed because:HTTPSession::connect()referencedSocketAddress::UNIX_LOCALSocketAddress::init()callednewLocal()which is only declared whenPOCO_HAS_UNIX_SOCKETis definedWebSocketImplconstructor referencedSocketAddress::UNIX_LOCALChanges
#if defined(POCO_HAS_UNIX_SOCKET)guard aroundUNIX_LOCALcheckisUnixLocal()andnewLocal()callUNIX_LOCALcheckPOCO_HAVE_CPP17_COMPILERmacro instead of direct__cplusplus >= 201703Lcheck for consistencyCloses #5064