Adapt makefiles for external dependencies#5049
Merged
Conversation
matejk
reviewed
Oct 22, 2025
Foundation/Makefile
Outdated
| # poco build system looks for sources in src/ | ||
| ifndef POCO_UNBUNDLED | ||
| prebuild = $(shell \ | ||
| mkdir -p src && \ |
Contributor
There was a problem hiding this comment.
src directory already exists in Foundation. no need to create it.
Contributor
Author
There was a problem hiding this comment.
Fixed in 9203877 — removed redundant src directory creation from all Makefiles (Foundation, JSON, PDF, XML)
matejk
reviewed
Oct 22, 2025
JSON/Makefile
Outdated
| else | ||
| objects += pdjson | ||
| prebuild = $(shell \ | ||
| mkdir -p src && \ |
matejk
reviewed
Oct 22, 2025
PDF/Makefile
Outdated
| # poco build system looks for sources in src/ | ||
| ifndef POCO_UNBUNDLED | ||
| prebuild = $(shell \ | ||
| mkdir -p src && \ |
matejk
reviewed
Oct 22, 2025
XML/Makefile
Outdated
| else | ||
| objects += $(expat_objects) | ||
| prebuild = $(shell \ | ||
| mkdir -p src && \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.