Replace NULL/0 with nullptr across codebase#5043
Merged
Conversation
4bcec6d to
eff345b
Compare
b3c3ec3 to
47242d9
Compare
47242d9 to
9331509
Compare
Contributor
Author
|
@aleks-f : I hope that I converted all of the instances in the code where 0 or NULL is used instead of nullptr. Changes revealed some latent problems in the code that might be worth resolving at some point. |
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
aleks-f
requested changes
Oct 23, 2025
Member
aleks-f
left a comment
There was a problem hiding this comment.
hidden variables are harmless and easily fixable - just remove auto* from the second instance, at least that's what it looks like to me - declared and initialized with nullptr, then declared again, so it only hides the unused nullptr one
key length I vaguely remember was complained about long time ago, but changing it would break code. I guess one day we'll have to do it
f6c8958 to
4dc1365
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4348