poco Zip: link ZLIB::ZLIB when unbundled#4987
Merged
matejk merged 1 commit intopocoproject:mainfrom Aug 8, 2025
Merged
Conversation
This was referenced Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Poco::Ziplibrary target uses ZLIB in its implementation (not in public headers).Since #4937, compilation may be broken when
POCO_UNBUNDLEDis True - previously, it was consuming ZLIB transitively via Foundation. Compilation may succeed on systems where zlib.h can be found by the compiler in the default paths, but this may not be the same version located by CMake and may cause linker issues (unlikely, but possible).This PR adds the missing requirement.
Fixes #4980