Fix Thread_POSIX not compiling with Emscripten#4986
Merged
matejk merged 2 commits intopocoproject:mainfrom Aug 8, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling
Thread_POSIX.cppwith emscripten on macOS, it fails, as it was trying to includesys/prctl.hwhich is a Linux only header file.Emscripten currently doesn't have support for getting/setting the thread name, so I decided to use the
POCO_NO_THREADNAMEdefine to disable the thread name functionality which can't compile.The current emscripten build on the CI is built with Ubuntu, which is why this issue didn't appear on the CI.
Changes:
sys/prctl.hinclude inThread_POSIX.cppto only be included whenPOCO_NO_THREADNAMEis not defined.POCO_NO_THREADNAMEfor emscripten.