Changed target uninstall to be named uninstall-poco#4941
Merged
matejk merged 23 commits intopocoproject:mainfrom May 28, 2025
Merged
Changed target uninstall to be named uninstall-poco#4941matejk merged 23 commits intopocoproject:mainfrom
matejk merged 23 commits intopocoproject:mainfrom
Conversation
* fix(VarHolder): MSVC warning pocoproject#4886 * fix(VarHolder): do not convert unsigned pocoproject#4886 * chore(SocketImpl): eliminate MSVC warning * fix(VarHolder): do not convert unsigned (extract unpreserveSign()) pocoproject#4886 * chore(testsuite): eliminate MSVC warnings * chore(VarHolder): simplify unpreserveSign using constexpr. --------- Co-authored-by: Matej Kenda <matejken@gmail.com>
…(move assertion out of ctor)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if I'm doing this right, but I was having pretty much the same issue as this person so I changed the name of the target as requested.