Fix dynamic var conversion precision check#4887
Closed
MduPlessis-1 wants to merge 1 commit intopocoproject:mainfrom
Closed
Fix dynamic var conversion precision check#4887MduPlessis-1 wants to merge 1 commit intopocoproject:mainfrom
MduPlessis-1 wants to merge 1 commit intopocoproject:mainfrom
Conversation
…sion loss check for negative values.
obiltschnig
reviewed
Feb 28, 2025
Member
obiltschnig
left a comment
There was a problem hiding this comment.
instead of llabs(), use std::abs()
aleks-f
requested changes
Feb 28, 2025
Member
aleks-f
left a comment
There was a problem hiding this comment.
@MduPlessis-1 please add a test for this
Contributor
Author
Using std::abs() here causes a compilation error for ambiguous overloads of abs() since this template can be called on unsigned types. So the options are:
|
Contributor
One solution would also be to use: |
Member
|
Something involving |
Contributor
|
Replaced with PR #4894 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take the absolute value of the value in numValDigits to fix the precision loss check for negative values. Fixes #4886.