Poco::Zip - Check archive consistency before extracting #4807
Merged
matejk merged 5 commits intopocoproject:mainfrom Dec 27, 2024
Merged
Poco::Zip - Check archive consistency before extracting #4807matejk merged 5 commits intopocoproject:mainfrom
matejk merged 5 commits intopocoproject:mainfrom
Conversation
aleks-f
approved these changes
Dec 3, 2024
matejk
reviewed
Dec 10, 2024
Contributor
matejk
left a comment
There was a problem hiding this comment.
Would it make sense to make it possible to ignore consistency check in case a user would desire to get the file out from the archive anyway?
Contributor
Author
|
I think it absolutely makes sense. Somehow I've missed this idea :( |
Contributor
|
@nyashbox, will you update the PR with optional consistency check? |
matejk
approved these changes
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4623
This is by far the best solution I've come up with. When decompressing all files, archive will be checked for consistency, but when decompressing single file, user should check archive manually. Example of the single file decompression with consistency check can be seen below (Original taken from the POCO Zip User Guide)
There are some other solutions I've considered: