Skip to content

Updated CMake to also include the generated pocomessage.rc File#4803

Closed
KevDi wants to merge 1 commit intopocoproject:mainfrom
KevDi:cmake_windows_eventlog_fix
Closed

Updated CMake to also include the generated pocomessage.rc File#4803
KevDi wants to merge 1 commit intopocoproject:mainfrom
KevDi:cmake_windows_eventlog_fix

Conversation

@KevDi
Copy link
Copy Markdown
Contributor

@KevDi KevDi commented Dec 2, 2024

I have added the pocomessage.rc in the CMakeLists. Currently it is missing and thats leads to the issue that the PocoFoundation.dll does not contains the Message Format for the Eventlog Channel in Windows. So the Eventviewer will show a warning about the missing Information.
I'm not the CMake Expert so i tried my best to solve it. If there is a better way then please let me know :).
At the moment i first need to create the File as an empty one because the custom_command is first called during the Build. So when running cmake .. it is unable to find the file because it is not there.
This will solve #3304

@obiltschnig
Copy link
Copy Markdown
Member

For consistency, this should be done in the POCO_MESSAGE CMake macro.

@obiltschnig
Copy link
Copy Markdown
Member

Proper fix in ff26c8e

@KevDi
Copy link
Copy Markdown
Contributor Author

KevDi commented Feb 11, 2025

@obiltschnig i was unsure what is the best place for this but looks good for me also to put it into the POCO_MESSAGES Macro

@matejk matejk closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants