Skip to content

Hide zlib and expat libs from the user of Poco libraries (replaces #4579)#4724

Merged
matejk merged 4 commits intomainfrom
4579_separate_lib_debs
Oct 4, 2024
Merged

Hide zlib and expat libs from the user of Poco libraries (replaces #4579)#4724
matejk merged 4 commits intomainfrom
4579_separate_lib_debs

Conversation

@matejk
Copy link
Copy Markdown
Contributor

@matejk matejk commented Oct 4, 2024

Replaces PR #4579. See details there.

Kari Argillander and others added 4 commits October 3, 2024 14:09
Nothing use this and it is not even included in Visual Studio project
files. Remove it so it will not confuse any more.
Hide zlib completly from user. This way we do not need to publish zlib.h
or zconfig.h.

As we now have two different pointer initalizing in constructor I choose
to use unique pointers so it is more obvious those are safe. I also
choose to use make_unique which default initalize z_stream_t. This makes
code more readable as we do not need to specifie every field of
z_stream_t. It really should not matter much if we initialize couple
field for nothing. If does we should add comment about that. Still
keeping _buffer without inializing as it is quite big.
Hide expat completly from user. This way we do not need to publish
expat.h or expat_external.h.

I move also headers to orignal locations so diff is smaller compared to
original.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant